Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.resession-nvim: init at 2024-08-16 #342170

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

PowerUser64
Copy link
Contributor

Description of changes

add stevearc/resession.nvim

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts are because you added a plugin to the end of the file, just put it somewhere in the middle. The order doesn't matter so much, as it is broken anyway. Though you have to fix those conflicts so it would be possible to merge this

But other than that, LGTM

@PowerUser64
Copy link
Contributor Author

Sweet, looks like merge conflicts have been resolved. Thanks @PerchunPak!

@PerchunPak
Copy link
Member

PerchunPak commented Oct 6, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 342170


x86_64-linux

✅ 2 packages built:
  • vimPlugins.resession-nvim
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.resession-nvim
  • vimPluginsUpdater

P.S. also tested manually on minimal nvim installation and it works

@PerchunPak
Copy link
Member

Just noticed that I got access to nix-community's darwin box!

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 342170


x86_64-darwin

✅ 2 packages built:
  • vimPlugins.resession-nvim
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.resession-nvim
  • vimPluginsUpdater

Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
@GaetanLepage GaetanLepage merged commit b5bb2bc into NixOS:master Oct 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants