httplib: 0.17.3 -> 0.18.0 #343963
Merged
httplib: 0.17.3 -> 0.18.0 #343963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonTorres
force-pushed
the
upload-adopt-httplib
branch
2 times, most recently
from
ab2a95c
to
9db8b65
Compare
AndersonTorres
force-pushed
the
upload-adopt-httplib
branch
from
9db8b65
to
29c1702
Compare
aidalgol
approved these changes
Sep 23, 2024
AndersonTorres
force-pushed
the
upload-adopt-httplib
branch
3 times, most recently
from
6061618
to
133e941
Compare
aidalgol
approved these changes
Sep 24, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4626 |
- finalAttrs - strictDeps - no nested with - add AndersonTorres as maintainer
Co-authored-by: R. RyanTM <ryantm-bot@ryantm.com>
By their own request.
- finalAttrs - nixfmt-rfc-style - adopted by AndersonTorres
Because setting it as true breaks obs-studio-plugins.advanced-scene-switcher
AndersonTorres
force-pushed
the
upload-adopt-httplib
branch
from
133e941
to
fe550ae
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2015 |
SuperSandro2000
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #343819 and fixes some failures.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.