immich: some improvements #344237
Merged
immich: some improvements #344237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for it and it cannot be used to override the machine learning component used by the immich package.
13 tasks
|
I just copied this from home assistant: I don't really care either way |
I figured. There it's useful because custom components might require overrides. But that's not a thing for immich.. |
jvanbruegge
approved these changes
Sep 24, 2024
dotlambda
changed the title
dotlambda
force-pushed
the
immich
branch
2 times, most recently
from
97cedc8
to
fff691c
Compare
A top-level attribute makes sure Hydra builds it (though that already happens on Linux through the NixOS test) and that nixpkgs-review picks it up.
Otherwise they could use different versions:
nix-repl> (immich.overrideAttrs { version = "0"; }).machine-learning.version
"1.115.0"
dotlambda
commented
Sep 24, 2024
| pyproject = true; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace pyproject.toml --replace-fail 'fastapi-slim' 'fastapi' | ||
|
|
||
| # AttributeError: module 'cv2' has no attribute 'Mat' |
There was a problem hiding this comment.
To me this smells like some issue with the way we package opencv4.
cc @philiptaron @SuperSandro2000 @mweinelt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.