vanguards: init at 0.3.1 #345996
vanguards: init at 0.3.1 #345996
Conversation
| @@ -0,0 +1,37 @@ | |||
| { pkgs }: | |||
| let | |||
| vgpkgs = import (pkgs.fetchFromGitHub { | |||
There was a problem hiding this comment.
Do not do this. If you have problems with the dependencies, please share that instead of trying to use a different revision
There was a problem hiding this comment.
Thank you, I didn't quite know how to approach this issue. I know the exact version of the dependencies (before the breaking API changes that made them unusuable for the original vanguards code), should I repackage them as separate, ancillary derivations?
There was a problem hiding this comment.
Issues with ipaddress that made me use an older nixpkgs version:
"ipadress has been removed because it is no longer required since python 2.7"
| Runs alongside tor and interacts with its control port | ||
| in order to protect and alert against guard node attacks on hidden services''; | ||
| }; | ||
| doCheck = false; |
There was a problem hiding this comment.
Can you explain why this is here?
There was a problem hiding this comment.
Because the vanguards test suite tries connecting to the internet making the evaluation fail
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff649add0>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/pytest/
| rev = "c3961ac40ca0bce67f79bc76021f5817730033b8"; | ||
| sha256 = "sha256-y5WwDLn2asYcA5hTl++UVeH5KZ8VRP4sMIjRv9y7GVE="; | ||
| }; | ||
| propagatedBuildInputs = with vgpkgs; [ |
There was a problem hiding this comment.
Why is this dangling on its own? This derivation is really hard to read.
There was a problem hiding this comment.
I am not sure I understand what you mean by "dangling on its own". The source repository does not have a requirements list or poetry equivalent so I had to explicitly add both of those libraries this way.
If I remove this bit the build fails with the following error message (linked with the removal of ipaddress I should think)
ERROR: Could not find a version that satisfies the requirement ipaddress>=1.0.17; python_version < "3" (from vanguards==0.3.1) (from versions: none)
ERROR: No matching distribution found for ipaddress>=1.0.17; python_version < "3" (from vanguards==0.3.1)
I used nixfmt on the derivation file and I am trying my best to make it more readable, do you have specific, actionable advice to point me in the right direction in order to improve readability?
ForgottenBeast
force-pushed
the
add-vanguards
branch
from
91847fd
to
202dca1
Compare
ForgottenBeast
force-pushed
the
add-vanguards
branch
from
202dca1
to
e14add6
Compare
Thank you for your time reviewing my PR and your feedback. I tried sticking to both:
I see that I should have spent more time looking at other PRs from more experienced members and will start to do so. |
ForgottenBeast
force-pushed
the
add-vanguards
branch
from
e14add6
to
86b2dae
Compare
add derivation for vanguards, a set of scripts that increase security for tor hidden services by protecting against guard discovery attacks resources: https://github.com/mikeperry-tor/vanguards https://spec.torproject.org/vanguards-spec/index.html?highlight=vanguards
ForgottenBeast
force-pushed
the
add-vanguards
branch
from
86b2dae
to
d957214
Compare
add derivation for vanguards, a set of scripts that increase security for tor hidden services by protecting against guard discovery attacks
resources:
https://github.com/mikeperry-tor/vanguards
https://spec.torproject.org/vanguards-spec/index.html?highlight=vanguards
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.