Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgmq: init at 1.4.4 #346486

Merged
merged 2 commits into from
Oct 8, 2024
Merged

pgmq: init at 1.4.4 #346486

merged 2 commits into from
Oct 8, 2024

Conversation

takeda
Copy link
Contributor

@takeda takeda commented Oct 4, 2024 •
edited
Loading

PGMQ is a message queue extension that allows to implement similar queuing that's available on AWS SQS or RSMQ.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4641

@takeda
Copy link
Contributor Author

takeda commented Oct 5, 2024

@SuperSandro2000 applied proposed fixes.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4653

h7x4
h7x4 reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash and fix up your commits so that there are two commits like this?

maintainers: add takeda
pgmq: init at 1.4.4

pkgs/servers/sql/postgresql/ext/pgmq.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/pgmq.nix Show resolved Hide resolved
zimward
zimward reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also squash fix commits.

pkgs/servers/sql/postgresql/ext/pgmq.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@takeda
Copy link
Contributor Author

takeda commented Oct 7, 2024

@h7x4 @zimward I applied your recommendations

@takeda takeda requested review from zimward and h7x4 October 7, 2024 23:48
zimward
zimward reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be good to go, but i know too little about postgresql extensions so somebody more knowledgeable then me should probably look over it one more time.

@SuperSandro2000 SuperSandro2000 merged commit f0668c1 into NixOS:master Oct 8, 2024
23 checks passed
@takeda takeda deleted the pgmq branch October 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimward zimward zimward left review comments

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@h7x4 h7x4 Awaiting requested review from h7x4

Assignees
No one assigned
Labels
8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@takeda @nixos-discourse @SuperSandro2000 @h7x4 @zimward