Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ryujinx: archive.org tarball mirror for release-24.05 #346714

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Nabile-Rahmani
Copy link
Contributor

@Nabile-Rahmani Nabile-Rahmani commented Oct 5, 2024

Fixes source builds for 24.05, as per emilazy's request.

Like on master, fetchzip requires the hash attribute to be explicit, double check it with nix hash to-sri --type sha256 1vf4xwn1z7bfm7c49r2yydx3dqqzqwp0qgzq12m9yskqsj898d63.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes source builds for 24.05, as per [emilazy's request](NixOS#346694 (review)).

Like on master, fetchzip requires the hash attribute to be explicit, double check it with `nix hash to-sri --type sha256 1vf4xwn1z7bfm7c49r2yydx3dqqzqwp0qgzq12m9yskqsj898d63`.
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed matching hash.

@emilazy emilazy merged commit 17ae88b into NixOS:release-24.05 Oct 5, 2024
8 of 10 checks passed
@emilazy
Copy link
Member

emilazy commented Oct 5, 2024

Thanks for handling this.

@Nabile-Rahmani Nabile-Rahmani deleted the patch-1 branch October 5, 2024 19:28
@Nabile-Rahmani
Copy link
Contributor Author

Thank you so much for accepting the fixes :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants