Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gokey: 0.1.2-unstable-2023-11-16 -> 0.1.3 #346749

Merged
merged 1 commit into from
Oct 6, 2024
Merged

gokey: 0.1.2-unstable-2023-11-16 -> 0.1.3 #346749

merged 1 commit into from
Oct 6, 2024

Conversation

con-f-use
Copy link
Contributor

@con-f-use con-f-use commented Oct 5, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@con-f-use
Copy link
Contributor Author

cloudflare/gokey#75

@con-f-use con-f-use marked this pull request as ready for review October 6, 2024 00:24
@con-f-use con-f-use force-pushed the gokey_update_v0.1.3 branch 2 times, most recently from d7f40c9 to f1943d2 Compare October 6, 2024 13:42
NickCao
NickCao reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the v prefix, LGTM.

pkgs/by-name/go/gokey/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/go/gokey/package.nix Show resolved Hide resolved
NickCao
NickCao approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for ofborg.

@NickCao NickCao merged commit ac2ff9a into NixOS:master Oct 6, 2024
27 of 29 checks passed
@con-f-use con-f-use deleted the gokey_update_v0.1.3 branch October 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@con-f-use @NickCao