-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
texlive: Adds patch for missing synctex header. (Fixes zathura build) #46376
Conversation
11k rebuilds. staging, maybe? |
@xeji probably (I'm still not clear when staging and not-staging has to happen, so I'll follow your lead.) |
@samueldr there seem to be no hard rules but >10k rebuilds definitely qualifies for staging as it would be a pain for people working on master... |
Oh, github's UI didn't make it obvious |
yep, changing base of an existing PR is always fun 😄 |
This seems like a known issue as other distributions (ArchLinux here) have patches fixing the issue. This hopefully fixes more than one dependant builds for ZHF 18.09.
a020470
to
75e35d3
Compare
Fixed, mentioning since you commented just before. |
@GrahamcOfBorg build texlive.bin.core |
Success on x86_64-linux (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
@GrahamcOfBorg build zathura |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: zathura Partial log (click to expand)
|
darwin timeout building llvm, nothing we can do about it on ofborg. |
Timed out, unknown build status on x86_64-linux (full log) Attempted: zathura Partial log (click to expand)
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: zathura Partial log (click to expand)
|
This seems like a known issue as other distributions (ArchLinux here) have patches fixing the issue. This hopefully fixes more than one dependant builds for ZHF 18.09. (cherry picked from commit 1ac912b)
picked to |
@samueldr unfortunately this doesn't seem to fix cc @timokau |
I've just worked on fixing this: Still testing but (now) looks correct. Edit: second try |
Currently running hydra jobset with above patch applied: https://hydra.mayflower.de/eval/4572#tabs-unfinished Will push to staging and staging-18.09 if it's successful. |
The automake file was patched but `automake` not run. Also since the texk/web2c folder is not in autoconfig's SUBDIRS the autoreconfHook has to be run in there. Completely fixes NixOS#46376
Now I'm wondering how I got it building... since I remember starting zathura to check it worked. I'm guessing I could have mistakenly used a stale |
Still doesn't fix zathura, but that looks unrelated, it definitely fixes the missing synctex header. |
The automake file was patched but `automake` not run. Also since the texk/web2c folder is not in autoconfig's SUBDIRS the autoreconfHook has to be run in there. Completely fixes #46376
Motivation for this change
This seems like a known issue as other distributions (ArchLinux here)
have patches fixing the issue.
This hopefully fixes more than one dependant builds for ZHF 18.09. #45960
This is marked WIP because I'll be using ofborg's output to figure out other affected packages, and see if there are issues... Though I expect the list to be a bit big since texlive is deeply entrenched.With a superficial look, it seems to only fix zathura builds.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)zathura notes
My current tests are that zathura builds, and starts. It seems that zathura could have other issues than that, making it subtly broken, while building. (Alternatively, I could be using it wrong.)
In the console:
In zathura's gui
I expect fully that those are irrelevant to the change from this PR.