-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailpile: 1.0.0rc2 -> 1.0.0rc6 #97274
Conversation
b840d01
to
403675c
Compare
also, partial duplicate of #97273 |
403675c
to
a9c88ff
Compare
Yes, I intended for #97273 to be merged first, then this atop it — sorry, thought I'd made that clear in the description, but I guess I forgot. |
please rebase on the latest master, and remove the imgsize commit |
a9c88ff
to
dcdf9b4
Compare
Have done — eval failure is due to |
there was fixup commit already pushed, do you mind rebasing again? |
dcdf9b4
to
f335cbd
Compare
Done! |
{ stdenv, fetchFromGitHub, python2Packages, gnupg1orig, openssl, git }: | ||
{ stdenv | ||
, fetchFromGitHub | ||
, python2Packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be updated to python3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about that, mailpile 1.0 target python 3+, actually don't know where dev are on this point, i ask here : mailpile/Mailpile#160
I marked this as stale due to inactivity. → More info |
Still actively developed and yet stuck on python2. Also marked as vulnerable and their issue tracker contains yet another security issue reported in 2021/10 that the upstream hasn't acknowledged yet. Mind blown. Closes: NixOS#135543, NixOS#97274, NixOS#97275
mailpile has been removed 369db3b |
This PR also removes the
meta.knownVulnerabilities
metadata from the package. The referenced discussion thread talks about 0.5.x versions of Mailpile; 1.0.0rc* are stated to be ready for packaging.Atop #97273.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)