Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to not use direct pushes anymore #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

infinisil
Copy link
Member

The section effectively said to use PR's already, but it still had a reference to a command that indicated a direct push should be used. There's no need to do that, a pull request is totally fine.

This comes out of a discussion on Matrix with @RaitoBezarius, related to NixOS/rfcs#156

@infinisil infinisil changed the title Update Final-Release.md to not use direct pushes anymore Update to not use direct pushes anymore Aug 13, 2023
Comment on lines -96 to +93
git push upstream master release-$NEWVER $NEWVER-beta staging-$NEWVER staging-next-$NEWVER
git push upstream release-$NEWVER $NEWVER-beta staging-$NEWVER staging-next-$NEWVER
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why master is included here, seems like a mistake since this section is about the release branch.

And btw, new branches don't count as directly pushed commits under GitHub, and neither do tags, so this works fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not pushed to master, we lose the beta tag on the next master commit objects, don't we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh TIL that tag objects are an actual thing and not just a pointer to Git commits. Will need some thought

@RaitoBezarius
Copy link
Member

All -S are lost in this PR, can you comment on whether this is intentional (i.e. you propose to drop -S) or it is implicit to keep doing them, in that case, I think we should provide alternative instructions.

@infinisil
Copy link
Member Author

@zimbatm @RaitoBezarius @figsoda: What specific branch protections were turned off to make the release work? And were they turned on again afterwards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants