MDL-59596 ddl: Added has_breaking_change_sqlmode()

NoelDeMartin · Mar 26, 2018 · f6b16e9 · f6b16e9
1 parent a15c745
commit f6b16e9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/dml/mariadb_native_moodle_database.php b/lib/dml/mariadb_native_moodle_database.php
@@ -94,6 +94,12 @@ protected function has_breaking_change_quoted_defaults() {
         return version_compare($version, '10.2.7', '>=');
     }
 
+    public function has_breaking_change_sqlmode() {
+        $version = $this->get_server_info()['version'];
+        // Breaking change since 10.2.4: https://mariadb.com/kb/en/the-mariadb-library/sql-mode/#setting-sql_mode.
+        return version_compare($version, '10.2.4', '>=');
+    }
+
     /**
      * It is time to require transactions everywhere.
      *

diff --git a/lib/dml/mysqli_native_moodle_database.php b/lib/dml/mysqli_native_moodle_database.php
@@ -817,6 +817,14 @@ protected function has_breaking_change_quoted_defaults() {
         return false;
     }
 
+    /**
+     * Indicates whether SQL_MODE default value has changed in a not backward compatible way.
+     * @return boolean True when SQL_MODE breaks BC; otherwise, false.
+     */
+    public function has_breaking_change_sqlmode() {
+        return false;
+    }
+
     /**
      * Returns moodle column info for raw column from information schema.
      * @param stdClass $rawcolumn