Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade solidity parser #1131

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Upgrade solidity parser #1131

merged 1 commit into from
Dec 28, 2020

Conversation

fvictorio
Copy link
Member

Closes #1130

@sisco0
Copy link
Contributor

sisco0 commented Dec 27, 2020 •
edited
Loading

Please take into account my comment at the source code. From my investigations it seems that the parsing ends when a || symbol is found. If one contract is found with pragma solidity ^0.5.0 || ^0.6.0 and another included one is found with pragma solidity ^0.6.0 || ^0.5.0, does it work?

@fvictorio
Copy link
Member Author

@sisco0 yes, this PR fixes that issue.

@alcuadrado alcuadrado merged commit 857d715 into master Dec 28, 2020
@alcuadrado alcuadrado deleted the issue-with-version-pragmas branch December 28, 2020 17:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HardHat 2.0.6 does not compile legit contracts (not a Solidity bug)
3 participants
@fvictorio @sisco0 @alcuadrado