Parsing error tag in JUnit reports tomasbjerre#115

Nov1kov · Nov 15, 2020 · 8853ccd · 8853ccd
1 parent f3e0e6f
commit 8853ccd
Show file tree

Hide file tree

Showing 3 changed files with 226 additions and 1 deletion.
diff --git a/src/main/java/se/bjurr/violations/lib/parsers/JUnitParser.java b/src/main/java/se/bjurr/violations/lib/parsers/JUnitParser.java
@@ -38,7 +38,8 @@ public Set<Violation> parseReportOutput(
           if (xmlr.getLocalName().equalsIgnoreCase("testcase")) {
             className = getAttribute(xmlr, "classname");
             name = getAttribute(xmlr, "name");
-          } else if (xmlr.getLocalName().equalsIgnoreCase("failure")) {
+          } else if (xmlr.getLocalName().equalsIgnoreCase("failure")
+              || xmlr.getLocalName().equalsIgnoreCase("error")) {
             final Violation v = this.parseFailure(xmlr, className, name, violationsLogger);
             if (v != null) {
               violations.add(v);

diff --git a/src/test/java/se/bjurr/violations/lib/JUnitTest.java b/src/test/java/se/bjurr/violations/lib/JUnitTest.java
@@ -222,4 +222,25 @@ public void testThatViolationsCanBeParsedFromJunit113() {
         .startsWith("shouldDrawIBIntoEmptyWorld : java.lang.AssertionError");
     assertThat(violation0.getSeverity()).isEqualTo(ERROR);
   }
+
+  @Test
+  public void testThatViolationsCanBeParsedFromJENKINS64117() {
+    final String rootFolder = getRootFolder();
+
+    final Set<Violation> actual =
+        violationsApi() //
+            .withPattern(".*/junit/JENKINS-64117\\.xml$") //
+            .inFolder(rootFolder) //
+            .findAll(JUNIT) //
+            .violations();
+
+    assertThat(actual) //
+        .hasSize(1);
+
+    final Violation violation0 = new ArrayList<>(actual).get(0);
+    assertThat(violation0.getFile())
+        .isEqualTo("eu/pinteam/kyoto/gunit/testenv/test/CalculationUtilTest.java");
+    assertThat(violation0.getMessage()).startsWith("runCalculationScriptTest : The container");
+    assertThat(violation0.getSeverity()).isEqualTo(ERROR);
+  }
 }
diff --git a/src/test/resources/junit/JENKINS-64117.xml b/src/test/resources/junit/JENKINS-64117.xml