Rewriting PiTestParser parser tomasbjerre#101

Nov1kov · Sep 27, 2020 · 91d02fa · 91d02fa
1 parent c8289ce
commit 91d02fa
Show file tree

Hide file tree

Showing 4 changed files with 391 additions and 66 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,11 @@ Changelog of Violations lib.
 ## Unreleased
 ### GitHub [#101](https://github.com/tomasbjerre/violations-lib/issues/101) Replace the regexp xml-parsing with STL xml parser  
 
+**Rewriting LintParser parser**
+
+
+[c8289ce3bc6142f](https://github.com/tomasbjerre/violations-lib/commit/c8289ce3bc6142f) Tomas Bjerre *2020-09-27 14:45:48*
+
 **Rewriting JSLintParser parser**
 
 

diff --git a/src/main/java/se/bjurr/violations/lib/parsers/PiTestParser.java b/src/main/java/se/bjurr/violations/lib/parsers/PiTestParser.java
@@ -4,57 +4,102 @@
 import static se.bjurr.violations.lib.model.Violation.violationBuilder;
 import static se.bjurr.violations.lib.reports.Parser.PITEST;
 import static se.bjurr.violations.lib.util.ViolationParserUtils.getAttribute;
-import static se.bjurr.violations.lib.util.ViolationParserUtils.getChunks;
-import static se.bjurr.violations.lib.util.ViolationParserUtils.getContent;
-import static se.bjurr.violations.lib.util.ViolationParserUtils.getIntegerContent;
 
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
-import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.TreeSet;
+import javax.xml.stream.XMLStreamConstants;
+import javax.xml.stream.XMLStreamReader;
 import se.bjurr.violations.lib.ViolationsLogger;
 import se.bjurr.violations.lib.model.Violation;
+import se.bjurr.violations.lib.util.ViolationParserUtils;
 
 public class PiTestParser implements ViolationsParser {
 
   @Override
   public Set<Violation> parseReportOutput(
-      final String string, final ViolationsLogger violationsLogger) throws Exception {
+      final String content, final ViolationsLogger violationsLogger) throws Exception {
     final Set<Violation> violations = new TreeSet<>();
-    final String mutations = getContent(string, "mutations");
-    final List<String> mutationChunks = getChunks(mutations, "<mutation", "</mutation>");
-    for (final String mutationChunk : mutationChunks) {
-      final String mutatedClass = getContent(mutationChunk, "mutatedClass");
-      final String sourceFile = getContent(mutationChunk, "sourceFile");
-      final String filename = this.toFilename(mutatedClass, sourceFile);
-      final String status = getAttribute(mutationChunk, "status");
-      final String detected = getAttribute(mutationChunk, "detected");
-      final String mutatedMethod = getContent(mutationChunk, "mutatedMethod");
-      final String methodDescription = getContent(mutationChunk, "methodDescription");
-      final String mutator = getContent(mutationChunk, "mutator");
-      final String message = status + ", " + mutator + ", " + methodDescription;
-      final Integer startLine = getIntegerContent(mutationChunk, "lineNumber");
-      final Integer index = getIntegerContent(mutationChunk, "index");
-      final Map<String, String> specifics = new HashMap<>();
-      specifics.put("detected", detected);
-      specifics.put("mutatedMethod", mutatedMethod);
-      specifics.put("mutatedClass", mutatedClass);
-      specifics.put("status", status);
-      specifics.put("methodDescription", methodDescription);
-      violations.add( //
-          violationBuilder() //
-              .setRule(mutator) //
-              .setSource(sourceFile) //
-              .setParser(PITEST) //
-              .setStartLine(startLine) //
-              .setColumn(index) //
-              .setFile(filename) //
-              .setSeverity(WARN) //
-              .setMessage(message) //
-              .setSpecifics(specifics) //
-              .build() //
-          );
+
+    try (InputStream input = new ByteArrayInputStream(content.getBytes(StandardCharsets.UTF_8))) {
+      final XMLStreamReader xmlr = ViolationParserUtils.createXmlReader(input);
+      String status = null;
+      String detected = null;
+      String mutatedClass = null;
+      String sourceFile = null;
+      String mutatedMethod = null;
+      String methodDescription = null;
+      String mutator = null;
+      int index = 0;
+      int startLine = 0;
+      while (xmlr.hasNext()) {
+        final int eventType = xmlr.next();
+        if (eventType == XMLStreamConstants.START_ELEMENT) {
+          if (xmlr.getLocalName().equalsIgnoreCase("mutation")) {
+            status = null;
+            detected = null;
+            mutatedClass = null;
+            sourceFile = null;
+            mutatedMethod = null;
+            methodDescription = null;
+            mutator = null;
+            index = 0;
+            startLine = 0;
+            status = getAttribute(xmlr, "status");
+            detected = getAttribute(xmlr, "detected");
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("mutatedClass")) {
+            mutatedClass = xmlr.getElementText();
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("sourceFile")) {
+            sourceFile = xmlr.getElementText();
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("mutatedMethod")) {
+            mutatedMethod = xmlr.getElementText();
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("methodDescription")) {
+            methodDescription = xmlr.getElementText();
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("mutator")) {
+            mutator = xmlr.getElementText();
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("lineNumber")) {
+            startLine = Integer.parseInt(xmlr.getElementText());
+          }
+          if (xmlr.getLocalName().equalsIgnoreCase("index")) {
+            index = Integer.parseInt(xmlr.getElementText());
+          }
+        }
+        if (eventType == XMLStreamConstants.END_ELEMENT) {
+          if (xmlr.getLocalName().equalsIgnoreCase("mutation")) {
+            final Map<String, String> specifics = new HashMap<>();
+            specifics.put("detected", detected);
+            specifics.put("mutatedMethod", mutatedMethod);
+            specifics.put("mutatedClass", mutatedClass);
+            specifics.put("status", status);
+            specifics.put("methodDescription", methodDescription);
+            final String filename = this.toFilename(mutatedClass, sourceFile);
+            final String message = status + ", " + mutator + ", " + methodDescription;
+            final Violation violation =
+                violationBuilder() //
+                    .setRule(mutator) //
+                    .setSource(sourceFile) //
+                    .setParser(PITEST) //
+                    .setStartLine(startLine) //
+                    .setColumn(index) //
+                    .setFile(filename) //
+                    .setSeverity(WARN) //
+                    .setMessage(message) //
+                    .setSpecifics(specifics) //
+                    .build();
+            violations.add(violation);
+          }
+        }
+      }
     }
     return violations;
   }

diff --git a/src/test/java/se/bjurr/violations/lib/PiTestTest.java b/src/test/java/se/bjurr/violations/lib/PiTestTest.java
@@ -29,9 +29,9 @@ public void testThatViolationsCanBeParsed() {
 
     assertThat(new ArrayList<>(actual).get(0).getFile()) //
         .isEqualTo("se/bjurr/violations/lib/example/CopyOfMyClass.java");
-    assertThat(new ArrayList<>(actual).get(0).getMessage()) //
-        .isEqualTo(
-            "NO_COVERAGE, org.pitest.mutationtest.engine.gregor.mutators.ReturnValsMutator, (Ljava/lang/Object;)Z");
+    assertThat(new ArrayList<>(actual).get(0).getMessage())
+        .startsWith(
+            "NO_COVERAGE, org.pitest.mutationtest.engine.gregor.mutators.ReturnValsMutator");
     assertThat(new ArrayList<>(actual).get(0).getStartLine()) //
         .isEqualTo(17);
     assertThat(new ArrayList<>(actual).get(0).getEndLine()) //