Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es_ES.lang #397

Merged
merged 3 commits into from
Jan 23, 2017
Merged

Update es_ES.lang #397

merged 3 commits into from
Jan 23, 2017

Conversation

nicolasdeory
Copy link
Contributor

It's ~98% complete. Please check if the important stuff (language.code, etc) is OK.

@Nuchaz
Copy link
Owner

Nuchaz commented Jan 23, 2017

Looks good but I think the casing on some of the stuff will have to be tweaked. For example OakFurniturePaneler.name= becomes oakFurniturePaneler.name=. Just the first letter should be lower case on all the wood stuff. (oak, spruce, birch, jungle, acacia, darkoak (both the d and o need to be lower cased), and framed) I've been using an enum for all the wood types and for some reason, minecraft 1.9 decided that my enum's HAVE to be lower case. Kind of annoying, but it had to happen.

@Nuchaz Nuchaz merged commit 97648aa into Nuchaz:master Jan 23, 2017
@nicolasdeory
Copy link
Contributor Author

nicolasdeory commented Jan 24, 2017

It is, indeed.
Unfortunately I can't try out the mod right now (don't have time to create a modded instance with latest ver. Bibliocraft in it), so I don't know if it'll work.

The thing is as I just checked in the commits, the keys were already spelled like that (first capital letter for the wood stuff).

I hope some spanish guy tries it out and posts an issue if they are having problems with the translation.

Thanks for clarifying nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants