Throw an error in case of dependency mismatch #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An app (or addon) that consumes ember-data should have: - either jquery - or ember-fetch version 6.0.0 or above Throw a build error if it's not the case.
NullVoxPopuli
approved these changes
Mar 9, 2019
runspired
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Throw an error in case of dependency mismatch An app (or addon) that consumes ember-data should have: - either jquery - or ember-fetch version 6.0.0 or above Throw a build error if it's not the case. * Remove ember-fetch as a peerDependency
runspired
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Fix lint error * Fix `_requireBuildPackages` error * Reset yarn.lock from master There seems to be some issues in the yarn.lock To solve them I ran: - `git checkout master yarn.lock` - `yarn` Throw an error in case of dependency mismatch (#2) * Throw an error in case of dependency mismatch An app (or addon) that consumes ember-data should have: - either jquery - or ember-fetch version 6.0.0 or above Throw a build error if it's not the case. * Remove ember-fetch as a peerDependency Move ember-fetch to dependencies (#3) Indeed, two `ember-fetch`'s modules are imported in rest-adapter.
NullVoxPopuli
pushed a commit
that referenced
this pull request
Apr 13, 2019
* Fix lint error * Fix `_requireBuildPackages` error * Reset yarn.lock from master There seems to be some issues in the yarn.lock To solve them I ran: - `git checkout master yarn.lock` - `yarn` Throw an error in case of dependency mismatch (#2) * Throw an error in case of dependency mismatch An app (or addon) that consumes ember-data should have: - either jquery - or ember-fetch version 6.0.0 or above Throw a build error if it's not the case. * Remove ember-fetch as a peerDependency Move ember-fetch to dependencies (#3) Indeed, two `ember-fetch`'s modules are imported in rest-adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A project that consumes ember-data should have:
Throw a build error if it's not the case.
Disclaimer: this PR forces the consuming app (or addon) to explicitely opt into jQuery (https://github.com/ember-learn/deprecation-app/pull/255/files). Is it acceptable?