New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement XState 5 API support in templates #479

Open

NullVoxPopuli wants to merge 18 commits into main from xstate5-implementation

Owner

NullVoxPopuli commented Jan 4, 2024 •

edited

Loading

This is the bulk of the XState 5 support, and is basically a total rewrite.

NullVoxPopuli added the breaking label

stackblitz bot commented Jan 4, 2024

Run & review this pull request in StackBlitz Codeflow.

NullVoxPopuli force-pushed the xstate5-implementation branch from 1ac1617 to e1bfcd0 Compare

January 4, 2024 21:59

NullVoxPopuli changed the title ~~XState 5~~ Implement XState 5 API support in templates

NullVoxPopuli force-pushed the xstate5-implementation branch from d08ffdd to 59bc717 Compare

January 5, 2024 14:41

github-advanced-security bot found potential problems

View reviewed changes

ember-statechart-component/src/-private/statechart-manager.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

ember-statechart-component/src/-private/statechart-manager.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

ember-statechart-component/src/-private/statechart-manager.ts Fixed Show fixed Hide fixed


          Progress

79e385a

Updates

Remove some deps

Deps

Deps

wip

wip

linting

lint:fix

updates

oofta

Remove unused file

something is wrong with the usage test

It seems the usage of gts at all is broken in this repo

I have a @glimmer/syntax mismatch somewhere

Grrr template-compiler

Add sidewatch

NullVoxPopuli force-pushed the xstate5-implementation branch from 17a3f9c to 79e385a Compare

October 6, 2024 21:12

NullVoxPopuli added 2 commits

October 6, 2024 21:19

eh

99fa2fc


          Use vite for tests

949fb5f

github-advanced-security bot found potential problems

View reviewed changes

test-app/tests/index.html

+                  <script type="module">
+                    import { start } from './test-helper';
+                    import.meta.glob("./**/*.{js,ts,gjs,gts}", { eager: true });

Check notice

Code scanning / CodeQL

Syntax error Note test

Error: Unexpected token

NullVoxPopuli added 7 commits

October 6, 2024 22:25

ooo

b090b79

ooo

d657133

ooo

a8f7a53

wip

188ab4e

wip

0ccfc84


          I need to define this?

f812ef1


          Demo is running

f5c2609

github-advanced-security bot found potential problems

View reviewed changes

ember-statechart-component/src/-private/statechart-manager.ts Fixed Show fixed Hide fixed

NullVoxPopuli added 3 commits

October 8, 2024 22:56


          Time to slowly fix the tests

ad6093b

woo

740372a

woo

5078f8c

github-advanced-security bot found potential problems

View reviewed changes

ember-statechart-component/src/-private/statechart-manager.js

+              import { capabilities } from '@ember/component';
+              import { destroy, isDestroying, associateDestroyableChild } from '@ember/destroyable';
+              import { waitForPromise } from '@ember/test-waiters';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import waitForPromise.

ember-statechart-component/src/-private/statechart-manager.js

+              import { destroy, isDestroying, associateDestroyableChild } from '@ember/destroyable';
+              import { waitForPromise } from '@ember/test-waiters';
+              import { toPromise, createActor } from 'xstate';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import toPromise.

NullVoxPopuli added 4 commits

October 9, 2024 22:11

woo

ea26e28

woo

878907b

woo

18a235e


          Usage-test is done

0c51c60

github-advanced-security bot found potential problems

View reviewed changes

ember-statechart-component/src/-private/statechart-manager.js

+                  }
+                  let options = {};
+                  let input = {};

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable input.

ember-statechart-component/src/-private/statechart-manager.js

+                  let options = {};
+                  let input = {};
+                  let context = {};

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable context.

ember-statechart-component/src/-private/statechart-manager.js

+                  let options = {};
+                  let input = {};
+                  let context = {};
+                  let snapshot = {};

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable snapshot.


          Update ember

cfcac54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels