Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] account_reconcile_widget : Fix analytic tags formatting #418

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

TeoGoddet
Copy link

Analytic tags are not correctly formatted when sent to the server after reconciliation, that lead to an error being raised

before this commit. analytic tags are not correctly formatted when sent to the server after reconciliation, that lead to an error being raised
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 9, 2022
@github-actions github-actions bot closed this Nov 13, 2022
@pedrobaeza pedrobaeza reopened this Jan 31, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been hit now by this problem with the following steps to reproduce:

  • Create a reconciliation model of type "Manually create a write-off on clicked button".
  • Show analytic on the configuration and show the optional column "Analytic tags".
  • Put any analytic tag.

When using such reconciliation model on the reconciliation, the analytic tag is not well formatted and you can't complete the reconciliation.

@TeoGoddet next time, that steps are the crucial one for reviewing the PR.

Merging for solving the problem:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-418-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 30c5c8e into OCA:14.0 Jan 31, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dccbed4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants