Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #537

Open
wants to merge 8 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #537

wants to merge 8 commits into from

Conversation

sonhd91
Copy link
Contributor

@sonhd91 sonhd91 commented Mar 10, 2023

@sonhd91 sonhd91 marked this pull request as ready for review March 10, 2023 08:16
@sonhd91 sonhd91 mentioned this pull request Mar 16, 2023
Open
5 tasks
@grindtildeath
Copy link
Contributor

@sonhd91 can you please rebase to have a runboat to test?

@sonhd91 sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from 00341af to f440e10 Compare June 10, 2023 03:34
@grindtildeath
Copy link
Contributor

@sonhd91 Look to work well, thx 👍

However, the view on invoices looks broken with the alert message message not displayed properly, can you please fix? 🙏
On v16 runbot:
image

@sonhd91 sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from f440e10 to e97a4aa Compare June 15, 2023 06:15
@sonhd91
Copy link
Contributor Author

sonhd91 commented Jun 15, 2023

@sonhd91 Look to work well, thx 👍

However, the view on invoices looks broken with the alert message message not displayed properly, can you please fix? 🙏 On v16 runbot: image

I updated it, please check again

@rousseldenis
Copy link
Sponsor

@sonhd91 Could you rebase ?

rousseldenis
rousseldenis approved these changes Sep 4, 2023
View reviewed changes
Copy link
Sponsor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review

@sbidoul sbidoul added this to the 16.0 milestone Jan 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
grindtildeath and others added 8 commits May 6, 2024 10:36
@grindtildeath @sonhd91
Add account_payment_mode_auto_reconcile
23b5931 
Override write instead of using onchange

Add missing utf-8 comment

Fix warning message

Restrict to customer invoices

Add readme and load tests

Improvements after reviews

Improve doc

Unreconcile only automatically reconciled payments
@vrenaville @sonhd91
[FIX] typo in variable name
469a393
@TDu @grindtildeath @sonhd91
Add auto reconcile only same journal (#2)
9159a18 
* Add auto reconcile only same journal

Add an option to auto reconcile only credits that are on the same
journal than the invoice.
This make sure that unrelated payment will not be used automatically.

* Update account_payment_mode_auto_reconcile/models/account_invoice.py

Co-Authored-By: Akim Juillerat <akim.juillerat@camptocamp.com>

* Update account_payment_mode_auto_reconcile/tests/test_partner_auto_reconcile.py

Co-Authored-By: Akim Juillerat <akim.juillerat@camptocamp.com>
@grindtildeath @sonhd91
FIX: Override invoice_validate instead of action_invoice_open
9f459b7 
This small change is needed since action_invoice_open filters
invoices that can be open from other invoices that cannot.

Therefore using invoice_validate here allows for better
customizations by ensuring that the invoices to be handled are
really open (i.e. have a move generated).
@grindtildeath @sonhd91
FIX: Use function to sort credits
70037fd 
As using reverse is not reliable to ensure oldest credits
will be reconciled first, use a function to sort the dicts
according to their id and allows inheritance.
@OCA-git-bot @sonhd91
[ADD] icon.png
f4f22b1
@sonhd91
[IMP] account_payment_mode_auto_reconcile: black, isort, prettier
11c853d
@sonhd91
[16.0][MIG]account_payment_mode_auto_reconcile: Migrate to version 16.0
17386a6
@sonhd91 sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from e97a4aa to 17386a6 Compare May 6, 2024 03:36
@sonhd91
Copy link
Contributor Author

sonhd91 commented May 6, 2024 •
edited
Loading

Code and functional review

@rousseldenis
Sorry, I missed this, branch rebased

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis rousseldenis mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@santostelmo santostelmo santostelmo approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sonhd91 @grindtildeath @rousseldenis @OCA-git-bot @santostelmo @sbidoul @vrenaville @TDu