Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_reconcile_oca: improve error messages and allow to reconcile with different partners #626

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

  • There was an error reading to the user due to read of "ir.model.fields" without sudo.
  • If you tried to reconcile journal items of different accounts, a technical error message was issued. Generate a more nice looking user-oriented message
  • Sometimes you may need to reconcile journal items where the partner is different. It's not a good practice
    but may need to be done in cases such as when an invoice and a payment are posted with two partners that
    are in reality the same company, or because you just need to reconcile to clean up.

@etobella

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

…ncile with different partners

Sometimes you may need to reconcile journal items where the partner is different. It's not a good practice
 but may need to be done in cases such as when an invoice and a payment are posted with two partners that
 are in reality the same company, or because you just need to reconcile to clean up.
Copy link

@norlinhenrik norlinhenrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etobella
Copy link
Member

etobella commented Feb 3, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-626-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9cca3d8 into OCA:16.0 Feb 3, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a173ce0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants