Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_reconcile_oca: Migration to 17.0 #630

Merged
merged 94 commits into from
Apr 26, 2024

Conversation

etobella
Copy link
Member

@etobella etobella commented Feb 8, 2024

@norlinhenrik @JordiBForgeFlow

TODO:

  • Migrate bank reconciliation widget
  • Migrate reconciliaion widget of account move lines
  • Move Code removed from Odoo EE

etobella and others added 30 commits February 7, 2024 22:09
* In "reconcile" tab, don't propose the move of the currently processed statement line

* In accounting, only select/search parent partners
* refactoring JS in order to add logic
* Improve views
* Minor fixes in Odoo code in order to fix all possible options
…of account move number (name) fot the counterpart account move line
Currently translated at 1.0% (1 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/es/
Currently translated at 25.0% (23 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/hr/
Currently translated at 81.5% (75 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/tr/
By default, account_account name is a char field. But if
l10n_multilang is installed, it is translatable, hence
the DB column is now a jsonb.
We must handle both cases in the select query.
Currently translated at 76.0% (70 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/pt_BR/
Currently translated at 100.0% (92 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/fr/
@pedrobaeza
Copy link
Member

They should be added in Weblate once this is merged.

@norlinhenrik
Copy link
Contributor

@xtanuiha You are welcome to review the PR and approve it if you think it is ready to merge.

<field name="foreign_currency_id" invisible="1" />
<field name="currency_id" invisible="1" />
<div class="o_form_statusbar o_account_reconcile_oca_statusbar">
<div class="o_statusbar_buttons">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles of these buttons are not very appealing; making these modifications would be an improvement.

<div class="d-flex gap-1">

@etobella etobella force-pushed the 17.0-mig-account_reconcile_oca branch from 8afe3e5 to 1321579 Compare April 21, 2024 00:22
@etobella etobella force-pushed the 17.0-mig-account_reconcile_oca branch from b629e53 to f85338f Compare April 22, 2024 12:38
@etobella
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-630-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 06518b0 into OCA:17.0 Apr 26, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61ec98f. Thanks a lot for contributing to OCA. ❤️

@etobella etobella deleted the 17.0-mig-account_reconcile_oca branch April 26, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.