[WIP][16.0][IMP] account_reconcile_oca: Create exchange diff move when concile c… #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrencies don't match
|
Hi @etobella, |
etobella
reviewed
Feb 9, 2024
| def create(self, vals_list): | ||
| if self.env.context.get("no_foreign_currency", False): | ||
| for vals in vals_list: | ||
| vals["debit_amount_currency"] = 0 |
There was a problem hiding this comment.
Why not credit? It seems something weird to do it with this context. I would recommend to give some more context to your issue, how it was raised and so on...
|
After reviewing Odoo Code for reconcile I do not agree in this approach. this fields are computed automatically on reconcile function.... Can you explain the reason of this PR? |
|
I haven't tried the PR yet, but want to solve this:
|
etobella
requested changes
Feb 9, 2024
…epending on acount type
|
Closing PR after checking the bug is coming indeed from Core Odoo 16. We are trying to get a solution but applied to core directly. |
|
Thanks @aritzolea for checking |
aritzolea
deleted the
16.0-imp-account_reconcile_oca-exchange_move_different_currencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urrencies don't match