Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_reconcile_oca: Pass partner parameter correctly to _get_write_off_move_lines_dict #670

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

PNurm
Copy link
Contributor

@PNurm PNurm commented Jun 19, 2024

Fixes #669

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-670-by-etobella-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 18, 2024
Signed-off-by etobella
@OCA-git-bot
Copy link
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-670-by-etobella-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member

@PNurm I just fixed your PR. You were missing two important things:

  • Commit message was not following OCA standard. Now it is
  • Pre-commit was not launched by you. Remember to active it by doing pre-commit install.

@etobella etobella changed the title Pass partner parameter correctly to _get_write_off_move_lines_dict [16.0][FIX] account_reconcile_oca: Pass partner parameter correctly to _get_write_off_move_lines_dict Jul 18, 2024
@etobella
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-670-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2354cad into OCA:16.0 Jul 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ef12871. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[16.0] account_reconcile_oca: Error when using counterpart reconcile model with taxes
3 participants