-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new rule for automatic reconciliation and a cron #7
Conversation
By default it runs one reconcile after the other to be more atomic and memory friendly. But you can set run_all agrument to have all reconcile run at once
Due to merge trouble
return result | ||
|
||
def _from(self, rec, *args, **kwargs): | ||
# Overriden to use a inner join |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate a bit more in the comment on why an inner join?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ask @mdietrichc2c it is a port of his MP from Launchpad
Can you provide some automated test, also to show how should this be used in practice? Thanks! |
I'm off for two week, please @mdietrichc2c can you take care of this. |
'installable': True, | ||
'images': [] | ||
} | ||
# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of those editor-specific comments. I do use vim myself but I keep my configuration in my own dotfiles.
A common practice with odoo staff, so I'm not blocking over that.
I rebased this PR as #16 |
you can |
@bwrsandman but @nbessi is on holiday and I don't have push access to his repo. |
Right! Didn't see that detail. |
Better pooler import
This allows for credit lines to use another bank statement as reference, and do a reconciliation with all its lines (debit AND credit, as the commission line can be created in that statement as well).
The main goal is to allow to create "bank lines" for when the payment for credit cards arrives, and reconcile it with a previous bank statement import of those cards.