-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python 3.10 #360
Comments
Travis still is not supporting python3.10 So I can not set this version in CI in order to reproduce it and auto-tested Could you check if it is working well without pylint-odoo (only pylint)? So, it could be an issue in pylint project instead |
By updating pylint, with this diff: diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 980193e..24e38f7 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -98,7 +98,7 @@ repos:
files: /__init__\.py$
additional_dependencies: ["flake8-bugbear==20.1.4"]
- repo: https://github.com/pycqa/pylint
- rev: pylint-2.5.3
+ rev: v2.12.2
hooks:
- id: pylint
name: pylint with optional checks
@@ -108,7 +108,7 @@ repos:
- --exit-zero
verbose: true
additional_dependencies:
- - isort==4.3.21
+ - isort==5.10.1
- pylint-odoo==3.6.0
- id: pylint
name: pylint with mandatory checks
@@ -116,7 +116,7 @@ repos:
- --valid_odoo_versions=14.0
- --rcfile=.pylintrc-mandatory
additional_dependencies:
- - isort==4.3.21
+ - isort==5.10.1
- pylint-odoo==3.6.0
- repo: https://github.com/pre-commit/mirrors-eslint
rev: v7.8.1 I get this different error:
Quoting from https://iscinumpy.dev/post/bound-version-constraints/ (go to the tl;dr of the tl;dr 😆):
So maybe we should just do that here and hope for the best. What do you think? |
@yajo your solution at moduon/oca-addons-repo-template@46b3b70 works for both old Pythons and new? Can be proposed to the main repo? |
Travis already enabled the py3.10 and even py3.11 I just have created the following PR: |
FYI the CI is installing correctly the package for py3.10 even py3.11 Could you try using the hook of pylint-odoo directly instead of pylint, please? More info: |
Updating as requested in OCA/pylint-odoo#360 (comment).
Done, see OCA/oca-addons-repo-template#149. |
Updating as requested in OCA/pylint-odoo#360 (comment).
FYI now we are supporting 3.11 too from github actions: |
Updating as requested in OCA/pylint-odoo#360 (comment).
Is your feature request related to a problem?
Yes, OCA/oca-addons-repo-template#80 when my local dev env uses python 3.10.
Describe the solution you'd like
Add support for python 3.10.
Describe alternatives you've considered
Disable this check, install a python 3.9 interpreter.
Additional context
isort 5.10.0 added support to python 3.10.
If I apply this diff
It still fails:
The text was updated successfully, but these errors were encountered: