fix(FPA): Do not look for particular substitution in theories #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simpler version of the fix from OCamlPro#1113 for the 2.5.x release branch.
Halbaroth
approved these changes
May 13, 2024
bclement-ocp
added a commit
to bclement-ocp/opam-repository
that referenced
this pull request
May 13, 2024
CHANGES: ### Bug fixes * Fix a long-standing soundness issue in the FPA module (OCamlPro/alt-ergo#1122, originally reported in OCamlPro/alt-ergo#1111) * Dolmen frontend incorrectly allowed semantic triggers outside of theory extensions (OCamlPro/alt-ergo#1122)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler version of the fix from #1113 for the 2.5.x release branch.