Partial support of the primitive bvnot #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no regression :) It is ready for review ;) |
bclement-ocp
requested changes
Jul 24, 2023
There was a problem hiding this comment.
I'm not very fond of neg_mode because the use of mode implies a more fundamental change of behavior to me. I'd rather call this just neg or maybe negated which I think is more clear that the function operates as usual, but computes the negation of the result.
But I don't really have a strong justification for this, so if you feel strongly about using neg_mode, it's fine by me.
bclement-ocp
approved these changes
Jul 25, 2023
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Sep 13, 2023
In PR OCamlPro#745 we correctly handled the case where uninterpreted terms appear deep within a bit-vector terms, but we accidentally missed the case where the whole bit-vector is itself an uninterpreted term, leading to unsoundness (see the attached test). This patch fixes the code to properly deal with `bvnot` applied to an uninterpreted term.
Halbaroth
pushed a commit
that referenced
this pull request
Sep 14, 2023
In PR #745 we correctly handled the case where uninterpreted terms appear deep within a bit-vector terms, but we accidentally missed the case where the whole bit-vector is itself an uninterpreted term, leading to unsoundness (see the attached test). This patch fixes the code to properly deal with `bvnot` applied to an uninterpreted term.
Halbaroth
pushed a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Sep 14, 2023
In PR OCamlPro#745 we correctly handled the case where uninterpreted terms appear deep within a bit-vector terms, but we accidentally missed the case where the whole bit-vector is itself an uninterpreted term, leading to unsoundness (see the attached test). This patch fixes the code to properly deal with `bvnot` applied to an uninterpreted term.
Halbaroth
added a commit
that referenced
this pull request
Sep 14, 2023
* Do not discard `bvnot` applied to uninterpreted terms In PR #745 we correctly handled the case where uninterpreted terms appear deep within a bit-vector terms, but we accidentally missed the case where the whole bit-vector is itself an uninterpreted term, leading to unsoundness (see the attached test). This patch fixes the code to properly deal with `bvnot` applied to an uninterpreted term. * Update the changes log for v2.5.1 * Review changes --------- Co-authored-by: Basile Clément <bc@ocamlpro.com>
Halbaroth
pushed a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Sep 15, 2023
In PR OCamlPro#745 we correctly handled the case where uninterpreted terms appear deep within a bit-vector terms, but we accidentally missed the case where the whole bit-vector is itself an uninterpreted term, leading to unsoundness (see the attached test). This patch fixes the code to properly deal with `bvnot` applied to an uninterpreted term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a partial support of the bitvector primitive
bvnot. Basically, the canonizer of the bitvector theory pushes the not operator to the leaves of the semantic value as much as it can.