Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kriged apportioned abundance documentation #216

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

brandynlucca
Copy link
Collaborator

This includes a draft of the apportion_abundance document that covers how kriged biomass is reallocated into estimates of abundance, which is not to be confused with apportioning abundance estimates that were, themselves, kriged. A variety of images have been included that can be swapped out for equations.

@leewujung
Copy link
Member

There's some weird missing ")" in the functions that is probably not used -- see https://github.com/OSOceanAcoustics/echopop/actions/runs/8455613434/job/23163503465?pr=216

I think it'll be good to resolve that before we merge this PR so that the main does not get broken.

@leewujung
Copy link
Member

Ok, so I think you branched out after you did the code changes, so the 2 PRs are mingled. I fixed it by removing the 2 testing_* files and fixed the missing ")" just so that this PR is clean.

@leewujung leewujung marked this pull request as ready for review September 27, 2024 02:27
@leewujung
Copy link
Member

See #218 for indexing!

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a PR to fix the indexing problems and simplified the text in brandynlucca#6.

I also created an issue #279 to reconcile repeated materials and notation differences between the 2 apportioning pages -- I'll take that on once this one is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Questions concerning back-calculated abundance apportionment docs: Fix index problem in Jolly-Hampton page
2 participants