python: enable ruff "G" (logging) checks

Oaroyal · May 22, 2023 · 21c2ee5 · 21c2ee5
1 parent 78c0282
commit 21c2ee5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -28,6 +28,7 @@ select = [
     "B",       # flake8-bugbear
     "E",       # pycodestyle
     "F",       # pyflakes
+    "G",       # flake8-logging-format
     "I",       # isort
 ]
 exclude = [

diff --git a/src/cockpit/bridge.py b/src/cockpit/bridge.py
@@ -95,7 +95,7 @@ def get_os_release():
             try:
                 file = open('/usr/lib/os-release', encoding='utf-8')
             except FileNotFoundError:
-                logger.warn("Neither /etc/os-release nor /usr/lib/os-release exists")
+                logger.warning("Neither /etc/os-release nor /usr/lib/os-release exists")
                 return {}
 
         with file:

diff --git a/src/cockpit/config.py b/src/cockpit/config.py
@@ -50,7 +50,7 @@ def get_u_int(self, section, key, default, maximum, minimum):
         try:
             int_val = int(value)
         except ValueError:
-            logger.warning(f'cockpit.conf: [{section}] {key} is not an integer')
+            logger.warning('cockpit.conf: [%s] %s is not an integer', section, key)
             return default
 
         return min(max(int_val, minimum), maximum)