Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information to *-config.cmake files #137

Merged
merged 1 commit into from
Oct 1, 2016
Merged

Add version information to *-config.cmake files #137

merged 1 commit into from
Oct 1, 2016

Conversation

jamiesnape
Copy link
Contributor

The presence of *-config-version.cmake files not withstanding, it is common to include version information in *-config.cmake files for ease of use by downstream projects.

@jslee02
Copy link
Contributor

jslee02 commented Sep 28, 2016

This change would be essential when an octomap dependent package wants to support for multiple version of octomap. FCL is doing in this way for instance. However, we couldn't use octomap-config.cmake file for this purpose (currently using pkg-config) since it doesn't convey the version information.

#
# ===================================================================================

@PACKAGE_INIT@

set(OCTOMAP_FOUND TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this separately tracked from this PR in #138 (same for the other ones)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@ahornung
Copy link
Member

@jslee02 I see, thanks for the quick explanation. I haven't seen providing this information in two places at the same time for CMake before (also not mentioned by the CMake docs), so I'm really wondering if that can't be done with the regular version info.

@jamiesnape
Copy link
Contributor Author

I haven't seen providing this information in two places at the same time for CMake before

Pretty common, for example, these Kitware projects:

@ahornung ahornung merged commit 50e61cd into OctoMap:devel Oct 1, 2016
@jamiesnape jamiesnape deleted the add-version-to-config branch October 1, 2016 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants