Also set lowercase octomap_* variables in CMake config #369
Conversation
|
Thanks! I'm just wondering, is this the correct "CMake way" to solve the problem? Looks a bit arcane to me to simply define both cases, instead of fixing the depending packages? (Ping @mwoehlke-kitware) |
|
I'd say it's probably fine either way. This would hardly be the first package to do such a thing. OTOH, I think it's okay if you want to insist downstream users fix themselves. |
|
I think part of the problem is that the project name and config file name is lower-cased, but the defined variables are upper-case. ament in ROS2 [as one case I know of] can find based on the XML (if I understand this correctly); and there a |
|
@mwoehlke-kitware @wxmerkt thanks for the clarification, makes sense! |
|
@wxmerkt I just released this fix with v1.9.8 in the repo, in case you want to update the ROS release as well. |
Relates to #138
We have seen issues where OctoMap did not get configured properly due to common use of
find_package(octomap REQUIRED)in downstream packages (i.e. lower-case octomap). This issue has become more common on ROS2 and previously was circumvented by a patch to change the LIBDIR. Defining both variables grandfathers in downstream users (including using ament-auto-configure) by also providing the required configuration variables with a lower-case as in the project name.