The linux configure-tentacle.sh script now supports setting comms ports other than 10943. #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #68270: Windows tentacle installer and linux install scripts should support configuring a tentacle to communicate with port 443.. |
LukeButters
force-pushed
the
sast/support-comms-alternate-ports-in-linux-config-script
branch
from
19db3b0
to
062b1b2
Compare
LukeButters
requested review from
evolutionise,
raynhamdev,
acodrington and
samdanaei
raynhamdev
reviewed
Feb 6, 2024
| @@ -100,6 +100,7 @@ function setupPollingTentacle { | |||
| rolesstring="" | |||
| workerpoolsstring="" | |||
| machinetype=1 | |||
| servercommsport=10943 | |||
There was a problem hiding this comment.
Out of curiosity, do we know why this was strictly only set to 10943 before?
There was a problem hiding this comment.
Probably because it is the default.
raynhamdev
reviewed
Feb 6, 2024
|
|
||
| case $doesconnecttosamedomain in | ||
| 2) | ||
| read -p "What is the Octopus Server comms address including port e.g. 'https://polling.<yoururl>.octopus.app:443' ?: " commsAddress |
There was a problem hiding this comment.
The public doco doesn't mention that the port number needs to be specified. Would it work if we do?
There was a problem hiding this comment.
I requested it since it makes the bash easier, otherwise we then need to ask for port if a port is not set.
Also yes this does work.
LukeButters
deleted the
sast/support-comms-alternate-ports-in-linux-config-script
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
[SC-68270]
Fixes: #793
Related to: #527
Results
Before
The script would always assume
10943as the comms port.After
It now asks if the comms port is at the same or different address:
which results in:
If the address is the same we also ask what port:
and the resulting command:
How to review this PR
Quality ✔️
Pre-requisites