Allowing ability to observe partial state. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odonno
requested changes
Mar 19, 2018
ReduxSimple/ReduxStore.cs
Outdated
| public IObservable<object> ObserveAction() | ||
| { | ||
| return _actionSubject.AsObservable(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Overloaded methods (with the same name) should be close to one another. The same should be applied for ObserveState.
|
@mhusainisurge Ey. Thanks for your first time contribution! I really enjoy seeing someone with interest on this project. Your code looks good. Will need to update the docs in consequence, it is no a subject on this PR so I don't force you with it. Anyway, if you make the changes on the line return on the file, I'll consider this PR OK and merged it right after. On the meantime, will figure out why appveyor builds are failing.. |
|
Ok, fixed. Build is now working like expected. |
|
Thanks for considering my PR. I have implemented the changes requested. Looking forward to more contributions! |
Odonno
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to implement enhancement #4. I generalized it a bit to allow using any arbitrary selector on the state. This is the my first contribution on Github, so I hope I got everything right. 😃