Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups after Verifier trait overhaul #200

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Cleanups after Verifier trait overhaul #200

merged 8 commits into from
Apr 5, 2024

Conversation

JoshOrndorff
Copy link
Contributor

This PR fixes a few bugs that were introduced with #172.

Specifically, it fixes two bugs:

  1. The wallet was not encoding the new strongly typed redeemers properly. We may be able to skip this encoding entirely in a followup now that we have more strongly typed redeemers. For now, I have got the encoding working again.
  2. When checking transactions in the pool (an off-chain call), we were calling for the block number which was not available at that time. I've fixed this by persisting the block number in storage between blocks.

I guess it is even more clear that we need the entire wallet script to run in CI now.

@JoshOrndorff JoshOrndorff changed the title Joshy debug wallet transactions Cleanups after Verifier trait overhaul Apr 5, 2024
@JoshOrndorff JoshOrndorff merged commit 2a241a4 into main Apr 5, 2024
5 of 6 checks passed
@JoshOrndorff JoshOrndorff deleted the joshy-debug-wallet-transactions branch April 5, 2024 18:48
@JoshOrndorff JoshOrndorff mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshOrndorff