Refactor 1 #3
Merged
Refactor 1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
OleksiiBulba
commented
Apr 29, 2021
OleksiiBulba
commented
- Reorganized files into .docker folder;
- Added Dockerfile for php container based on php-fpm-alpine image;
- Nginx used alpine image;
- Added php ini files;
- Refactored nginx conf file into template for nginx container; instead of three different conf files for every env now only one conf template;
- Removed default values in env variables in conf template file, and added them to docker-compose.*.yaml files;
- Added folder and file to gitignore;
- Reorganized files into .docker file; - Added Dockerfile for php container based on php-fpm-alpine image; - Nginx used alpine image; - Added php ini files; - Refactored nginx conf file into template for nginx container; instead of three different conf files for every env now only one conf template;
- removed default values in env variables in conf template file, and added them to docker-compose.*.yaml files - added folder and file to gitignore; - rewrote Dockerfile - fixed path to docker-compose in mk files - fixed text in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.