Merge pull request #2444 from OmniSharp/dev/jorobich/add-comments

Add comment to app.config explaining System.Memory versioning
OmniSharp · Sep 1, 2022 · bda8cf1 · bda8cf1
2 parents fcc960c + c4fd91a
commit bda8cf1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/src/OmniSharp.Http.Driver/app.config b/src/OmniSharp.Http.Driver/app.config
@@ -65,6 +65,8 @@
 
             <dependentAssembly>
                 <assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
+                <!-- System.Memory assembly version does not align with the NuGet package version. 
+                     Package version 4.5.5 ships with assembly version 4.0.1.2 -->
                 <bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" />
             </dependentAssembly>
         </assemblyBinding>

diff --git a/src/OmniSharp.Stdio.Driver/app.config b/src/OmniSharp.Stdio.Driver/app.config
@@ -65,6 +65,8 @@
 
             <dependentAssembly>
                 <assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
+                <!-- System.Memory assembly version does not align with the NuGet package version. 
+                     Package version 4.5.5 ships with assembly version 4.0.1.2 -->
                 <bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" />
             </dependentAssembly>
         </assemblyBinding>

diff --git a/tests/app.config b/tests/app.config
@@ -49,6 +49,8 @@
 
             <dependentAssembly>
                 <assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
+                <!-- System.Memory assembly version does not align with the NuGet package version. 
+                     Package version 4.5.5 ships with assembly version 4.0.1.2 -->
                 <bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" />
             </dependentAssembly>
         </assemblyBinding>