Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Roslyn rename options #1495

Merged
merged 10 commits into from
Jun 14, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented May 14, 2019

This PR introduces support (via omnisharp.json and the rest of OmniSharp configuration model) for Roslyn renaming options.

{
    "RenameOptions": {
        "RenameInComments": true,
        "RenameOverloads": true,
        "RenameInStrings": true
   }
}

The solutions builds upon the original workspace options extensibility created for FormattingOptions. The options are respected in real time - changes are propagated to the workspace without the need to restart OmniSharp.

Following options are supported (all of them are switched off by default and need to be enabled explicitly):

RenameOverloads

rename2

RenameInComments

rename

RenameInStrings

rename3

I will update the documentation https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options once this is merged.

@filipw
Copy link
Member Author

filipw commented Jun 14, 2019

since this was approved I will merge it - I will have a separate PR soon touching similar code and don't want to get into conflicts and keep this open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants