Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MSBuild and Mono from release packages #2360

Merged
merged 26 commits into from
Mar 25, 2022
Merged

Remove MSBuild and Mono from release packages #2360

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cd4de6d
Remove MSBuild and Mono from release packages
JoeRobich Feb 19, 2022
bfa5b55
Fix publishing errors.
JoeRobich Mar 17, 2022
4689758
Update vm images used in CI
JoeRobich Mar 18, 2022
6e017f8
Remove reference to `omnisharp.useGlobalMono` from messages
JoeRobich Mar 18, 2022
1be42f3
Remove `UseBundledOnly` MSBuild Option.
JoeRobich Mar 18, 2022
b1fe1e6
Adjust project capabilities test
JoeRobich Mar 18, 2022
556b29f
Include SQLitePCLRaw in .NET Framework test output
JoeRobich Mar 18, 2022
bd23d5a
Fix test
JoeRobich Mar 18, 2022
c0cdf55
Simplify getting MSBuildLocator in tests
JoeRobich Mar 20, 2022
784f2a7
Merge branch 'master' into remove-tooling
JoeRobich Mar 20, 2022
d34a431
Restore Mono test behavior
JoeRobich Mar 20, 2022
6071873
Merge branch 'remove-tooling' of github.com:JoeRobich/omnisharp-rosly…
JoeRobich Mar 20, 2022
ca1a590
Copy only the necessary MSBuild libraries
JoeRobich Mar 20, 2022
b0eb7d6
Copy Mono MSBuild files when testing but do not overwrite
JoeRobich Mar 20, 2022
78bdcc4
Copy SQLite libraries during Mono tests
JoeRobich Mar 20, 2022
3ccc284
Run OmniSharpMSBuild.Tests on Mono in CI
JoeRobich Mar 20, 2022
9855687
Remove unused code
JoeRobich Mar 20, 2022
1bb8c93
Skip NET5+ MSBuild tests against Mono
JoeRobich Mar 20, 2022
097a354
Restore run script in Mono O# packages
JoeRobich Mar 21, 2022
c24a1e0
Add warning when using deprecated 'UseBundledOnly' option
JoeRobich Mar 24, 2022
f176822
Create logger before using it.
JoeRobich Mar 24, 2022
c38a67f
Use nullable type for option value.
JoeRobich Mar 24, 2022
c662bba
Parse option as a string
JoeRobich Mar 24, 2022
8201fef
Pass default value when getting option
JoeRobich Mar 24, 2022
18bc3ba
Handle null configuration
JoeRobich Mar 24, 2022
24c0c0f
Update changelog
JoeRobich Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle null configuration
  • Loading branch information
@JoeRobich
JoeRobich committed Mar 24, 2022
commit 18bc3bae83d3c30bd4f47a61ec3a976347fd89bb
2 changes: 1 addition & 1 deletion src/OmniSharp.Host/MSBuild/Discovery/MSBuildLocator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ protected override void DisposeCore(bool disposing)

public static MSBuildLocator CreateDefault(ILoggerFactory loggerFactory, IAssemblyLoader assemblyLoader, IConfiguration msbuildConfiguration)
{
var useBundledOnly = msbuildConfiguration.GetValue<bool>("UseBundledOnly", false);
var useBundledOnly = msbuildConfiguration?.GetValue<bool>("UseBundledOnly") ?? false;
if (useBundledOnly)
{
var logger = loggerFactory.CreateLogger<MSBuildLocator>();
Expand Down