Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextEdits support to InlayHints #2385

Merged
merged 10 commits into from
Apr 18, 2022
Merged

Add TextEdits support to InlayHints #2385

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77eca56
Update Roslyn to 4.3.0-1.22215.1
JoeRobich Apr 16, 2022
4224a2b
Add TextEdits to InlayHints
JoeRobich Apr 16, 2022
850d6cd
Increase import completion timeout in tests
JoeRobich Apr 16, 2022
e5f8c7c
Fix typo
JoeRobich Apr 16, 2022
b346915
Use TextChangeHelper
JoeRobich Apr 16, 2022
2f88954
Fix EditorConfig Formatting test
JoeRobich Apr 16, 2022
1340c24
Fix analyzer test
JoeRobich Apr 17, 2022
4995db0
Fix Cake completion test.
JoeRobich Apr 17, 2022
2a76dd1
Remove AdditionalTextEdits from Cake completion items
JoeRobich Apr 18, 2022
c7b3354
Delay getting Completion instead of polling in LSP tests.
JoeRobich Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Cake completion test.
  • Loading branch information
@JoeRobich
JoeRobich committed Apr 17, 2022
commit 4995db0da90d7667bb487f8c161b0520f2ef472a
12 changes: 2 additions & 10 deletions tests/OmniSharp.Cake.Tests/CompletionFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using OmniSharp.Cake.Services.RequestHandlers.Completion;
Expand Down Expand Up @@ -103,16 +102,9 @@ public async Task ShouldRemoveAdditionalTextEditsFromResolvedCompletions()

// Populating the completion cache should take no more than a few ms, don't let it take too
// long
var cts = new CancellationTokenSource(millisecondsDelay: ImportCompletionTimeout);
await Task.Run(async () =>
{
while (completions.IsIncomplete)
{
completions = await FindCompletionsAsync(fileName, input, host);
cts.Token.ThrowIfCancellationRequested();
}
}, cts.Token);
await Task.Delay(ImportCompletionTimeout);

completions = await FindCompletionsAsync(fileName, input, host);
Assert.False(completions.IsIncomplete);
Assert.Contains("Regex", completions.Items.Select(c => c.TextEdit.NewText));

Expand Down