Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Learning Button hover glow + recentering of copyright #130

Closed
the3plet opened this issue Oct 23, 2022 · 10 comments · Fixed by #135
Closed

Start Learning Button hover glow + recentering of copyright #130

the3plet opened this issue Oct 23, 2022 · 10 comments · Fixed by #135
Assignees
@the3plet
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@the3plet
Copy link
Contributor

  • Adding hover glow to the button will give much cleaner look
    current button state:
    image

  • Copyright text not seems to be aligned
    image
@the3plet the3plet added bug Something isn't working help wanted Extra attention is needed labels Oct 23, 2022
@jbampton jbampton removed their assignment Oct 23, 2022
@the3plet
Copy link
Contributor Author

@jbampton @BaseMax can you please assign me, i can help out

@jbampton
Copy link
Contributor

Hey @the3plet you are now assigned. Thanks 💯

@jbampton
Copy link
Contributor

Current site is deployed from the alpha-version branch

Screen Shot 2022-10-24 at 12 20 30 am

Screen Shot 2022-10-24 at 12 20 45 am

@the3plet
Copy link
Contributor Author

so i should be cloning alpha branch right?

@jbampton
Copy link
Contributor

Sorry about the confusion.

We are using FTP to deploy the main branch to our own service provider.

The old site is on alpha-version.

So please work on the main branch

@BaseMax
Copy link
Member

BaseMax commented Oct 23, 2022 •
edited
Loading

Currently, the main branch is active and deployed on the https://onelang.org website.
so in this case, if you want to fix that bug you need to clone and send PR to that branch.

Keep calm and love programming. happy hacktoberfest

@the3plet
Copy link
Contributor Author

Okey🥂

@BaseMax
Copy link
Member

BaseMax commented Oct 23, 2022

Welcome.

Our GitHub actions are defined for the main branch. so I am right. the main branch is active now.
https://github.com/One-Language/Website/blob/main/.github/workflows/deploy.yml

on:
  push:
    branches:
      - main

@jbampton
Copy link
Contributor

Ah yes that was my addition today :)

And I still got mixed up

the3plet added a commit to the3plet/Website-1 that referenced this issue Oct 23, 2022
@the3plet
+ slight hover glow added
d10cdb0 
+ Aligned Copyright to center
issue One-Language#130
@the3plet the3plet mentioned this issue Oct 23, 2022
Merged
@savi001
Copy link

savi001 commented Oct 27, 2022

i am interested to work on it ,
can you please assign this to me .

@jbampton jbampton linked a pull request Feb 6, 2023 that will close this issue
button hover glow + copyright aligned (issue #130) #135
Merged
jbampton added a commit that referenced this issue Feb 6, 2023
@the3plet @jbampton
button hover glow + copyright aligned (issue #130) (#135)
7cdfcb4 
* + slight hover glow added
+ Aligned Copyright to center
issue #130

---------

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@the3plet the3plet

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

button hover glow + copyright aligned (issue #130) the3plet/Website-1
4 participants
@jbampton @BaseMax @the3plet @savi001