Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async for sending over websockets #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koch-t
Copy link

@koch-t koch-t commented Nov 20, 2013

The implementation prior can heavily suffer from the slow subscriber issue where one client can possible slow down the other clients and even the filewriter.

NOTE:
I'm not sure if this change, sending over websockets async doesn't allow for new issues such as dead sockets that will never be closed or huge backlogs on one client.
Maybe a zeromq fan-out model where each client works on it's own queue is more reliable, this would also reduce locking issues when adding new subscribers, as each client will work on a different thread.
Using a ZeroMQ poller can also implement a heartbeat which currently is not implemented yet implied by the header

The implementation prior can heavily suffer from the slow subscriber issue where one client can possible slow down the other clients and even the filewriter.

NOTE:
I'm not sure if this change, sending over websockets async doesn't allow for new issues such as dead sockets that will never be closed or huge backlogs on one client.
Maybe a zeromq fan-out model where each client works on it's own queue is more reliable, this would also reduce locking issues when adding new subscribers, as each client will work on a different thread.
Using a ZeroMQ poller can also implement a heartbeat which currently is not implemented yet implied by the header
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants