-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/map type toggle button #43
Conversation
</button> | ||
|
||
<style> | ||
.map-type-button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency, you can use the Tailwind CSS inline at the button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed that we use tailwind in the codebase. I’m not familiar with it yet, but I plan to learn it and rewrite the styles using tailwind. I initially wrote in regular css because I saw that the location button was already styled that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, no problem. We will add the button CSS code into a global CSS file in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done 👍🏻 .
@Ahmedhossamdev please rebase against the latest changes in |
@aaronbrethorst Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I suspect we'll have to change some behavior of this down the road, but this is a solid and useful addition. thank you!
No description provided.