Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue16 core UI #19

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Issue16 core UI #19

merged 7 commits into from
Jun 28, 2024

Conversation

hilmyveradin
Copy link
Collaborator

Within this PR, it's included the following:

  1. Create base view for origin and destination view
  2. Add base map view with mock region data
  3. Create sheet which utilize MKLocalSearchCompleter

Question:

  1. Is this scope ticket already correct? Or does it need some improvement in terms of UI tweaks and functionality?
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-27.at.18.33.37.mov

aaronbrethorst
aaronbrethorst requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! I have noted some changes I'd like to see in here before merging, but they're really all just minor stylistic changes. thanks!

OTPKitDemo/Features/OriginDestination/Components/OriginDestinationSheetView.swift Outdated Show resolved Hide resolved
OTPKitDemo/Features/OriginDestination/Components/OriginDestinationSheetView.swift Outdated Show resolved Hide resolved
OTPKitDemo/Features/OriginDestination/Components/OriginDestinationSheetView.swift Show resolved Hide resolved
OTPKitDemo/Features/OriginDestination/Environment/OriginDestinationSheetEnvironment.swift Show resolved Hide resolved
OTPKitDemo/Features/OriginDestination/Environment/OriginDestinationSheetEnvironment.swift Show resolved Hide resolved
OTPKitDemo/Features/OriginDestination/OriginDestinationViewModel.swift Outdated Show resolved Hide resolved
OTPKitDemo/Features/OriginDestination/OriginDestinationViewModel.swift Outdated Show resolved Hide resolved
OTPKitDemo/OTPKitDemoApp.swift Outdated Show resolved Hide resolved
OTPKitDemo/Services/LocationServices.swift Outdated Show resolved Hide resolved
OTPKitDemo/Services/LocationServices.swift Show resolved Hide resolved
@hilmyveradin hilmyveradin mentioned this pull request Jun 28, 2024
Closed
@hilmyveradin
Copy link
Collaborator Author

Hi @aaronbrethorst, I already add some documentation and delete uneccessary code as you requested. Kindly check this out again 😁

aaronbrethorst
aaronbrethorst approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 👍

@aaronbrethorst aaronbrethorst merged commit 5c3ddc9 into OneBusAway:main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilmyveradin @aaronbrethorst