Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tripplanner and map overlay #35

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Add tripplanner and map overlay #35

merged 5 commits into from
Jul 31, 2024

Conversation

hilmyveradin
Copy link
Collaborator

@hilmyveradin hilmyveradin commented Jul 30, 2024 •
edited
Loading

Description

This PR includes adding selectable direction in trip planner

Related Issues

#34

Media

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-30.at.20.30.04.mov

Test Instructions

  1. Select Origin and destination. It can be from search location, current location, and direct map selection
  2. Select itinerary
  3. See the map overlay. Check if it's visible

aaronbrethorst
aaronbrethorst approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

@aaronbrethorst aaronbrethorst merged commit 1c96451 into main Jul 31, 2024
2 of 4 checks passed
@aaronbrethorst aaronbrethorst deleted the add-tripplanner-and-map-overlay branch July 31, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilmyveradin @aaronbrethorst