Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Favorite click with Long and Tap Gesture #46

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix Favorite click with Long and Tap Gesture #46

merged 2 commits into from
Aug 11, 2024

Conversation

hilmyveradin
Copy link
Collaborator

@hilmyveradin hilmyveradin commented Aug 11, 2024 •
edited by aaronbrethorst
Loading

Related Issues

Fixes #42

Media

image
image

Test Instructions

  1. Add Favorite Location
  2. Try the short and long tap gesture. Short click should add teh marker and location and long click should make the Confirmation Dialog Appear
  3. Try to click details, it should make the sheet detail appears
  4. Try to delete directly form the confirmation dialog

aaronbrethorst
aaronbrethorst approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit 05a0fd1 into main Aug 11, 2024
4 checks passed
@aaronbrethorst aaronbrethorst deleted the manage-favorite-click branch August 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let me use favorites as origin or destination
2 participants
@hilmyveradin @aaronbrethorst