Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify OTPKit repo to Swift Package #55

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Conversation

hilmyveradin
Copy link
Collaborator

@hilmyveradin hilmyveradin commented Aug 13, 2024

Description

Make the whole repo as Swift Package

Related Issues

Fixes #45

Test Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce.

  1. Try the demo project
  2. See if the OTPKit is integrated correctly

Additional Context

  • XCodegen is removed to make it more simple if people want to use it. They can go straight to the demo project without generating the xcodeproj file
  • gitignore for xcodeproj and pbxproj file is also removed

@hilmyveradin hilmyveradin changed the title feat: modify OTPKit to swift pacakge Modify OTPKit repo to Swift Package Aug 13, 2024
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! Before this gets merged, though, the tests need to be restored and the CI needs to be fixed. let me know if you need help with either

@hilmyveradin
Copy link
Collaborator Author

nice work! Before this gets merged, though, the tests need to be restored and the CI needs to be fixed. let me know if you need help with either

Understood! About the test, should I restore the test for the demo app or the package?

@aaronbrethorst
Copy link
Member

Package if that's possible

@hilmyveradin
Copy link
Collaborator Author

Hi @aaronbrethorst, I already add the test and fix the CI. For CI, I only add the test build for testing purposes because Swift Package only able to build the test scheme

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit 8a21c08 into main Aug 14, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the swift-package-manager branch August 14, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift Package Manager Support
2 participants