Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onboarding for otpkitdemo #65

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

hilmyveradin
Copy link
Collaborator

Description

This PR adds custom region for demo testing purposes

Related Issues

#64

Media

image

Test Instructions

  1. Open OTPKitDemo
  2. Choose region
  3. Try to perform the trip planner for selected region. See if it works or not

@hilmyveradin hilmyveradin changed the title add onboarding for otpkitdemo Add onboarding for otpkitdemo Aug 28, 2024
* Change the hardcoded regions data format to include `URL` and `CLLocationCoordinate2D` objects, so that we don't have to construct them manually later
* Change the background color of the view to match the `List`'s background color
* Use a built-in button style for the "Submit" button and change its title to "OK"
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, Hilmy!

@aaronbrethorst aaronbrethorst merged commit 77ff1e3 into main Aug 28, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the add-custom-region-onboarding branch August 28, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants