Skip to content

Commit

Permalink
Update Java templates to correctly close parenthesis (#17961)
Browse files Browse the repository at this point in the history 
* update java templates to correctly close parenthesis

* add closing parenthesis to missing java template
  • Loading branch information
@l3ender
l3ender committed Feb 26, 2024
1 parent 4ba187a commit 22c52d3
Show file tree
Hide file tree
Showing 12 changed files with 53 additions and 53 deletions.
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/Java/api.mustache
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class {{classname}} {
* {{summary}}
* {{notes}}
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
{{#returnType}}
* @return {{.}}
Expand Down
4 changes: 2 additions & 2 deletions modules/openapi-generator/src/main/resources/Java/libraries/apache-httpclient/api.mustache
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class {{classname}} {
* {{summary}}
* {{notes}}
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
{{#returnType}}
* @return {{returnType}}
Expand All @@ -76,7 +76,7 @@ public class {{classname}} {
* {{summary}}
* {{notes}}
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
* @param additionalHeaders additionalHeaders for this call
{{#returnType}}
Expand Down
6 changes: 3 additions & 3 deletions modules/openapi-generator/src/main/resources/Java/libraries/native/api.mustache
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public class {{classname}} {
* {{summary}}
* {{notes}}
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
{{#returnType}}
* @return {{#asyncNative}}CompletableFuture<{{/asyncNative}}{{returnType}}{{#asyncNative}}>{{/asyncNative}}
Expand Down Expand Up @@ -225,7 +225,7 @@ public class {{classname}} {
* {{summary}}
* {{notes}}
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
* @return {{#asyncNative}}CompletableFuture<{{/asyncNative}}ApiResponse<{{returnType}}{{^returnType}}Void{{/returnType}}>{{#asyncNative}}>{{/asyncNative}}
* @throws ApiException if fails to make API call
Expand Down Expand Up @@ -548,7 +548,7 @@ public class {{classname}} {
private {{{dataType}}} {{paramName}}; // {{description}} (required)
{{/requiredParams}}
{{#optionalParams}}
private {{{dataType}}} {{paramName}}; // {{description}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}
private {{{dataType}}} {{paramName}}; // {{description}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}})
{{/optionalParams}}

private API{{operationId}}Request(Builder builder) {
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/java-helidon/client/libraries/se/api.mustache
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public interface {{classname}} {
* {{.}}
{{/notes}}
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
* @return {@code {{>operationResponseSig}}}
{{#isDeprecated}}
Expand Down
4 changes: 2 additions & 2 deletions ...s/openapi-generator/src/main/resources/java-helidon/client/libraries/se/api_impl.mustache
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public class {{classname}}Impl implements {{classname}} {
* Optional customization point for subclasses.
*
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
* @return WebClientRequestBuilder for {{operationId}}
*/
Expand Down Expand Up @@ -161,7 +161,7 @@ public class {{classname}}Impl implements {{classname}} {
*
* @param webClientRequestBuilder the request builder to use for submitting the request
{{#allParams}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}){{/isContainer}}{{/required}}
* @param {{paramName}} {{description}}{{#required}} (required){{/required}}{{^required}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}){{/required}}
{{/allParams}}
* @return {@code {{>operationResponseSig}}} for the submitted request
*/
Expand Down
8 changes: 4 additions & 4 deletions ...t/echo_api/java/apache-httpclient/src/main/java/org/openapitools/client/api/QueryApi.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ public String testQueryStyleDeepObjectExplodeTrueObjectAllOf(TestQueryStyleDeepO
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @return String
* @throws ApiException if fails to make API call
*/
Expand All @@ -439,7 +439,7 @@ public String testQueryStyleFormExplodeFalseArrayInteger(List<Integer> queryObje
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @param additionalHeaders additionalHeaders for this call
* @return String
* @throws ApiException if fails to make API call
Expand Down Expand Up @@ -497,7 +497,7 @@ public String testQueryStyleFormExplodeFalseArrayInteger(List<Integer> queryObje
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @return String
* @throws ApiException if fails to make API call
*/
Expand All @@ -509,7 +509,7 @@ public String testQueryStyleFormExplodeFalseArrayString(List<String> queryObject
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @param additionalHeaders additionalHeaders for this call
* @return String
* @throws ApiException if fails to make API call
Expand Down
8 changes: 4 additions & 4 deletions samples/client/echo_api/java/native/src/main/java/org/openapitools/client/api/QueryApi.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ private HttpRequest.Builder testQueryStyleDeepObjectExplodeTrueObjectAllOfReques
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @return String
* @throws ApiException if fails to make API call
*/
Expand All @@ -582,7 +582,7 @@ public String testQueryStyleFormExplodeFalseArrayInteger(List<Integer> queryObje
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @return ApiResponse&lt;String&gt;
* @throws ApiException if fails to make API call
*/
Expand Down Expand Up @@ -660,7 +660,7 @@ private HttpRequest.Builder testQueryStyleFormExplodeFalseArrayIntegerRequestBui
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @return String
* @throws ApiException if fails to make API call
*/
Expand All @@ -672,7 +672,7 @@ public String testQueryStyleFormExplodeFalseArrayString(List<String> queryObject
/**
* Test query parameter(s)
* Test query parameter(s)
* @param queryObject (optional
* @param queryObject (optional)
* @return ApiResponse&lt;String&gt;
* @throws ApiException if fails to make API call
*/
Expand Down
8 changes: 4 additions & 4 deletions ...nt/petstore/java-helidon-client/se/src/main/java/org/openapitools/client/api/FakeApi.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ public interface FakeApi {
/**
* To test enum parameters
* To test enum parameters
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumQueryModelArray (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumQueryModelArray (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @return {@code ApiResponse<Void>}
*/
Expand Down
20 changes: 10 additions & 10 deletions ...etstore/java-helidon-client/se/src/main/java/org/openapitools/client/api/FakeApiImpl.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -690,14 +690,14 @@ public ApiResponse<Void> testEnumParameters(List<String> enumHeaderStringArray,
* Creates a {@code WebClientRequestBuilder} for the testEnumParameters operation.
* Optional customization point for subclasses.
*
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumQueryModelArray (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumQueryModelArray (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @return WebClientRequestBuilder for testEnumParameters
*/
Expand Down Expand Up @@ -733,14 +733,14 @@ protected WebClientRequestBuilder testEnumParametersRequestBuilder(List<String>
* Optional customization point for subclasses.
*
* @param webClientRequestBuilder the request builder to use for submitting the request
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumQueryModelArray (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumQueryModelArray (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @return {@code ApiResponse<Void>} for the submitted request
*/
Expand Down Expand Up @@ -998,7 +998,7 @@ public ApiResponse<Void> testQueryParameterCollectionFormat(List<String> pipe, L
* @param url (required)
* @param context (required)
* @param allowEmpty (required)
* @param language (optional
* @param language (optional)
* @return WebClientRequestBuilder for testQueryParameterCollectionFormat
*/
protected WebClientRequestBuilder testQueryParameterCollectionFormatRequestBuilder(List<String> pipe, List<String> ioutil, List<String> http, List<String> url, List<String> context, String allowEmpty, Map<String, String> language) {
Expand Down Expand Up @@ -1032,7 +1032,7 @@ protected WebClientRequestBuilder testQueryParameterCollectionFormatRequestBuild
* @param url (required)
* @param context (required)
* @param allowEmpty (required)
* @param language (optional
* @param language (optional)
* @return {@code ApiResponse<Void>} for the submitted request
*/
protected ApiResponse<Void> testQueryParameterCollectionFormatSubmit(WebClientRequestBuilder webClientRequestBuilder, List<String> pipe, List<String> ioutil, List<String> http, List<String> url, List<String> context, String allowEmpty, Map<String, String> language) {
Expand Down
20 changes: 10 additions & 10 deletions ...nt/petstore/java/apache-httpclient/src/main/java/org/openapitools/client/api/FakeApi.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1136,14 +1136,14 @@ public void testEndpointParameters(BigDecimal number, Double _double, String pat
/**
* To test enum parameters
* To test enum parameters
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumQueryModelArray (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumQueryModelArray (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @throws ApiException if fails to make API call
*/
Expand All @@ -1155,14 +1155,14 @@ public void testEnumParameters(List<String> enumHeaderStringArray, String enumHe
/**
* To test enum parameters
* To test enum parameters
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumQueryModelArray (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumQueryModelArray (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @param additionalHeaders additionalHeaders for this call
* @throws ApiException if fails to make API call
Expand Down Expand Up @@ -1631,7 +1631,7 @@ public void testNullable(ChildWithNullable childWithNullable, Map<String, String
* @param url (required)
* @param context (required)
* @param allowEmpty (required)
* @param language (optional
* @param language (optional)
* @throws ApiException if fails to make API call
*/
public void testQueryParameterCollectionFormat(List<String> pipe, List<String> ioutil, List<String> http, List<String> url, List<String> context, String allowEmpty, Map<String, String> language) throws ApiException {
Expand All @@ -1648,7 +1648,7 @@ public void testQueryParameterCollectionFormat(List<String> pipe, List<String> i
* @param url (required)
* @param context (required)
* @param allowEmpty (required)
* @param language (optional
* @param language (optional)
* @param additionalHeaders additionalHeaders for this call
* @throws ApiException if fails to make API call
*/
Expand Down
12 changes: 6 additions & 6 deletions .../client/petstore/java/native-async/src/main/java/org/openapitools/client/api/FakeApi.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1353,13 +1353,13 @@ private HttpRequest.Builder testEndpointParametersRequestBuilder(BigDecimal numb
/**
* To test enum parameters
* To test enum parameters
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @return CompletableFuture&lt;Void&gt;
* @throws ApiException if fails to make API call
Expand All @@ -1384,13 +1384,13 @@ public CompletableFuture<Void> testEnumParameters(List<String> enumHeaderStringA
/**
* To test enum parameters
* To test enum parameters
* @param enumHeaderStringArray Header parameter enum test (string array) (optional
* @param enumHeaderStringArray Header parameter enum test (string array) (optional)
* @param enumHeaderString Header parameter enum test (string) (optional, default to -efg)
* @param enumQueryStringArray Query parameter enum test (string array) (optional
* @param enumQueryStringArray Query parameter enum test (string array) (optional)
* @param enumQueryString Query parameter enum test (string) (optional, default to -efg)
* @param enumQueryInteger Query parameter enum test (double) (optional)
* @param enumQueryDouble Query parameter enum test (double) (optional)
* @param enumFormStringArray Form parameter enum test (string array) (optional
* @param enumFormStringArray Form parameter enum test (string array) (optional)
* @param enumFormString Form parameter enum test (string) (optional, default to -efg)
* @return CompletableFuture&lt;ApiResponse&lt;Void&gt;&gt;
* @throws ApiException if fails to make API call
Expand Down
Loading

0 comments on commit 22c52d3

Please sign in to comment.