-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][C++] special characters and case sensitivity and key "operator" in properties not respected #4320
Closed
5 of 6 tasks
Labels
Comments
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
lwlee2608
added a commit
to lwlee2608/openapi-generator
that referenced
this issue
Oct 30, 2019
wing328
pushed a commit
that referenced
this issue
Nov 1, 2019
5 tasks
Closed via #4323. Thanks for the PR by @lwlee2608 |
jimschubert
added a commit
that referenced
this issue
Nov 3, 2019
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits) smaller tests, better code format (#4355) csharp-netcore: Replace null literals with default (#4345) [core] consider polymorphism when computing unused schemas (#4335) Fix issue 4326 forward throws for delegate to main method (#4327) [kotlin][client] annotate api exceptions (#4339) refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353) Remove deprecated API use of ObjectFactory.property() (#2613) (#4352) [python][metadata]: Adding license and author fields (#4318) [Python] Avoid pep8 violation (#4316) [JS] Update package.json (#4261) Add slash-arun to Python technical committee (#4354) [typescript-fetch] Fix discriminator mapping name (#4340) fix security alerts reported by github (#4344) fix cpp-restbed-server json field serialization #4320 (#4323) typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341) fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337) update samples (#4334) Prepare 4.2.0 release (#4333) [FEATURE][Haskell] Haskell-Servant serves static files (#4058) [FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056) ...
jimschubert
added a commit
that referenced
this issue
Nov 3, 2019
* master: (142 commits) smaller tests, better code format (#4355) csharp-netcore: Replace null literals with default (#4345) [core] consider polymorphism when computing unused schemas (#4335) Fix issue 4326 forward throws for delegate to main method (#4327) [kotlin][client] annotate api exceptions (#4339) refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353) Remove deprecated API use of ObjectFactory.property() (#2613) (#4352) [python][metadata]: Adding license and author fields (#4318) [Python] Avoid pep8 violation (#4316) [JS] Update package.json (#4261) Add slash-arun to Python technical committee (#4354) [typescript-fetch] Fix discriminator mapping name (#4340) fix security alerts reported by github (#4344) fix cpp-restbed-server json field serialization #4320 (#4323) typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341) fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337) update samples (#4334) Prepare 4.2.0 release (#4333) [FEATURE][Haskell] Haskell-Servant serves static files (#4058) [FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056) ...
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this issue
Nov 3, 2019
* master: (141 commits) smaller tests, better code format (OpenAPITools#4355) csharp-netcore: Replace null literals with default (OpenAPITools#4345) [core] consider polymorphism when computing unused schemas (OpenAPITools#4335) Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327) [kotlin][client] annotate api exceptions (OpenAPITools#4339) refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353) Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352) [python][metadata]: Adding license and author fields (OpenAPITools#4318) [Python] Avoid pep8 violation (OpenAPITools#4316) [JS] Update package.json (OpenAPITools#4261) Add slash-arun to Python technical committee (OpenAPITools#4354) [typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340) fix security alerts reported by github (OpenAPITools#4344) fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323) typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341) fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337) update samples (OpenAPITools#4334) Prepare 4.2.0 release (OpenAPITools#4333) [FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058) [FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report Checklist
Description
When generating a server stub, cpp-restbed-server in my case, all functions reading the values through the keys of a JSON request will automatically stripe certain special characters from the keys set the first letter to uppercase and add an underscore to certain keywords (e.g.
operator
). This causes thept.put()
,pt.get()
etc, which apparently are case sensitive to fail aquiring and passing data to and from a JSON file/array.The OAS also states that keys are case sensitive
I haven't confirmed if any other languages/generators are affected by this problem, but it might be possible!
openapi-generator version
OpenAPI declaration file content or url
caseSensitive.yaml
Generates the following function
toJsonString()
:comments indicate the expected output
Command line used for generation
java -jar openapi-generator-cli.jar generate -i .\caseSensitive.yaml -g cpp-restbed-server -o .\openapi-server\
Steps to reproduce
Simply don't use an uppercase letter as first character for a property key.
Related issues/PRs
Suggest a fix
The text was updated successfully, but these errors were encountered: