-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Collapse Spec Options to Maven Plugin #17714
Adds Collapse Spec Options to Maven Plugin #17714
Conversation
i think it's doable now. if you use the |
d041351
to
873094c
Compare
I see, but looking for this capability in the maven generator as we build against poms. In our workflow, the openapi spec is committed with the java service repository. The repository build process will then generate the service resource handlers and a java client. We now have cases where clients in other languages need to generate a client, and while we lack a swagger hub store, adding the spec to the artifact repository works as a good alternative. |
@bbdouglas, @sreeshas, @jfiala, @lukoyanov, @cbornet, @jeff9finger, @karismann, @Zomzog, @lwlee2608, or @martin-mfg do one you mind reviewing this PR? |
@dchauhan-twilio thanks for the explanation. we can give it a try. can you please update the readme with the new option? |
CI tests failed: https://github.com/OpenAPITools/openapi-generator/actions/runs/7673305908/job/21045742400?pr=17714 can you please take a look? |
873094c
to
de1a753
Compare
Good idea, added in the last commit de1a753
After the latest commit, tests have passed. Looks like it was unrelated to this PR, but something central that failed. |
@bbdouglas, @sreeshas, @jfiala, @lukoyanov, @cbornet, @jeff9finger, @karismann, @Zomzog, @lwlee2608, or @martin-mfg, I see you are the maintainers for this section of the repo. Can you please review? |
tests still failed. can you please take another look? |
* Adds a collapsedSpec option to the maven plugin that produces a single-file representation of the spec in the output directory. * Adds a includeCollapsedSpecInArtifacts option to the maven plugin that adds the collapsed spec file to the maven artifacts.
* Adds the new options to the maven plugin README.md.
* Corrects the casing of one of the schema files that was causing the tests to fail.
de1a753
to
43b8a92
Compare
@wing328 Apologies for the delay, been a busy week struggled to replicate locally. Found the bug in the end (it was a casing issue :face_palm). I have validated the workflows pass in my fork (see dchauhan-twilio#2) so hopefully once the workflows are approved to run in this repo, it will pass here too. |
No need to sorry. We all appreciate your contributions. Just triggered the workflow and let's see how that goes. |
@wing328 looks like all the tests passed. Can this be merged? |
looks good. let's give it a try thanks for the PR. |
* Adds Collapse Spec Optionss to Maven Plugin * Adds a collapsedSpec option to the maven plugin that produces a single-file representation of the spec in the output directory. * Adds a includeCollapsedSpecInArtifacts option to the maven plugin that adds the collapsed spec file to the maven artifacts. * Address Feedback Round 1 * Adds the new options to the maven plugin README.md. * Fixes Unit Tests * Corrects the casing of one of the schema files that was causing the tests to fail.
How to manually verify
collapsedSpec
andincludeCollapsedSpecInArtifacts
options to the plugin configuration.mvn deploy
collapsedSpec
value.collapsedSpec
value.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)